Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes theme header logo and icon upload #18851

Merged

Conversation

wiardvanrij
Copy link
Contributor

@wiardvanrij wiardvanrij commented Oct 26, 2018

Description (*)

With the change of "fileuploader" to "imageuploader" the correct formElement was not updated to match the new "imageuploader".

Fixed Issues (if relevant)

  1. Unable to upload Logo, Magento 2.3.0 Beta18 #18688: Unable to upload Logo, Magento 2.3.0 Beta18
  2. ...

Manual testing scenarios (*)

  1. Use magento2.3 development branche
  2. Content -> Design -> Configuration -> edit any Default Store View
  3. Other Settings -> Header -> try to upload a favicon or logo

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

@magento-engcom-team
Copy link
Contributor

Hi @wiardvanrij. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Oct 27, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@rogyar rogyar self-assigned this Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18851-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Oct 27, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18851//admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 27, 2018
@magento-engcom-team
Copy link
Contributor

@wiardvanrij thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@wiardvanrij
Copy link
Contributor Author

Anyone knows why travis did not run properly?

@rogyar
Copy link
Contributor

rogyar commented Oct 28, 2018

The issue with Travis will be fixed soon

@magento-engcom-team magento-engcom-team merged commit ba69bfe into magento:2.3-develop Oct 31, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 31, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@magento-engcom-team
Copy link
Contributor

Hi @wiardvanrij. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@ekisaj
Copy link

ekisaj commented Dec 18, 2018

Hello, I am facing the same problem, I cannot upload logo/favicon image. I am using Magento 2.3.0 and php 7.2.8. Anyone with a fix?

@webusat
Copy link

webusat commented Feb 1, 2019

I have the same problem with a fresh install of 2.3 trying to change the Transactional Email Logo. I click Upload to upload the logo image, choose the image and I get a running circle for a second and nothing is ever added. No logo image is displayed in the backend at all and the image in the email is still the default Magento logo. I can confirm that changing the core design_config_form.xml (not recommended) @valikvali does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet